From f59402ee58b659c22c9d173546d7e8da27e82f91 Mon Sep 17 00:00:00 2001
From: Jean-Christian Denis <contact@jcdenis.fr>
Date: Tue, 20 Dec 2022 21:25:13 +0100
Subject: [PATCH] phpstan, php-cs-fixer review

---
 _admin.php                     |  2 +-
 _init.php                      |  2 +-
 _install.php                   |  2 +-
 _widgets.php                   |  3 ++-
 inc/class.cinecturlink2.php    |  6 +++---
 inc/lib.cinecturlink2.list.php | 14 +++++++-------
 6 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/_admin.php b/_admin.php
index 4091b09..eccef82 100644
--- a/_admin.php
+++ b/_admin.php
@@ -76,7 +76,7 @@ function cinecturlink2AdminIcon(): string
     return urldecode(dcPage::getPF('cinecturlink2/icon.svg'));
 }
 
-function cinecturlink2AdminPerm(): bool
+function cinecturlink2AdminPerm(): string
 {
     return dcCore::app()->auth->makePermissions([dcAuth::PERMISSION_CONTENT_ADMIN]);
 }
diff --git a/_init.php b/_init.php
index 36e9d4d..55ac9c6 100644
--- a/_init.php
+++ b/_init.php
@@ -17,5 +17,5 @@ if (!defined('DC_RC_PATH')) {
 class initCinecturlink2
 {
     public const CINECTURLINK_TABLE_NAME = 'cinecturlink2';
-    public const CATEGORY_TABLE_NAME = 'cinecturlink2_cat';
+    public const CATEGORY_TABLE_NAME     = 'cinecturlink2_cat';
 }
diff --git a/_install.php b/_install.php
index 27bc2c6..186556e 100644
--- a/_install.php
+++ b/_install.php
@@ -16,7 +16,7 @@ if (!defined('DC_CONTEXT_ADMIN')) {
 
 try {
     if (!dcCore::app()->newVersion(
-        basename(__DIR__), 
+        basename(__DIR__),
         dcCore::app()->plugins->moduleInfo(basename(__DIR__), 'version')
     )) {
         return null;
diff --git a/_widgets.php b/_widgets.php
index 5ce7778..450334f 100644
--- a/_widgets.php
+++ b/_widgets.php
@@ -163,7 +163,8 @@ class cinecturlink2Widget
             return null;
         }
 
-        $C2 = new cinecturlink2();
+        $C2     = new cinecturlink2();
+        $aprams = [];
 
         if ($w->category) {
             if ($w->category == 'null') {
diff --git a/inc/class.cinecturlink2.php b/inc/class.cinecturlink2.php
index 35dc984..000fd35 100644
--- a/inc/class.cinecturlink2.php
+++ b/inc/class.cinecturlink2.php
@@ -37,10 +37,10 @@ class cinecturlink2
     {
         dcCore::app()->blog->settings->addNamespace('cinecturlink2');
 
-        $this->con   = dcCore::app()->con;
-        $this->table = dcCore::app()->prefix . initCinecturlink2::CINECTURLINK_TABLE_NAME;
+        $this->con       = dcCore::app()->con;
+        $this->table     = dcCore::app()->prefix . initCinecturlink2::CINECTURLINK_TABLE_NAME;
         $this->cat_table = dcCore::app()->prefix . initCinecturlink2::CATEGORY_TABLE_NAME;
-        $this->blog  = dcCore::app()->con->escape(dcCore::app()->blog->id);
+        $this->blog      = dcCore::app()->con->escape(dcCore::app()->blog->id);
     }
 
     /**
diff --git a/inc/lib.cinecturlink2.list.php b/inc/lib.cinecturlink2.list.php
index 5fd1be2..d924895 100644
--- a/inc/lib.cinecturlink2.list.php
+++ b/inc/lib.cinecturlink2.list.php
@@ -105,10 +105,10 @@ class adminlistCinecturlink2
     private function linkLine($checked)
     {
         $cols = [
-            'check' => '<td class="nowrap minimal">' .
+            'check'  => '<td class="nowrap minimal">' .
                 form::checkbox(['entries[]'], $this->rs->link_id, ['checked' => $checked]) .
                 '</td>',
-            'title' => '<td class="nowrap" scope="row">' .
+            'title'  => '<td class="nowrap" scope="row">' .
                 '<a href="' . dcCore::app()->adminurl->get(
                     'admin.plugin.cinecturlink2',
                     ['part' => 'link', 'linkid' => $this->rs->link_id, 'redir' => $this->redir]
@@ -118,10 +118,10 @@ class adminlistCinecturlink2
             'author' => '<td class="nowrap">' .
                 html::escapeHTML($this->rs->link_author) .
                 '</td>',
-            'desc' => '<td class="maximal">' .
+            'desc'   => '<td class="maximal">' .
                 html::escapeHTML($this->rs->link_desc) .
                 '</td>',
-            'link' => '<td class="nowrap">' .
+            'link'   => '<td class="nowrap">' .
                 '<a href="' . $this->rs->link_url . '" title="' .
                     html::escapeHTML($this->rs->link_url) .
                 '">' . __('URL') . '</a> ' .
@@ -129,18 +129,18 @@ class adminlistCinecturlink2
                     html::escapeHTML($this->rs->link_img) .
                 '">' . __('image') . '</a> ' .
                 '</td>',
-            'cat' => '<td class="nowrap minimal">' .
+            'cat'    => '<td class="nowrap minimal">' .
                 '<a href="' . dcCore::app()->adminurl->get(
                     'admin.plugin.cinecturlink2',
                     ['part' => 'cat', 'catid' => $this->rs->cat_id, 'redir' => $this->redir]
                 ) . '" title="' . __('Edit') . '">' .
                 html::escapeHTML($this->rs->cat_title) . '</a>' .
                 '</td>',
-            'note' => '</td>' .
+            'note'   => '</td>' .
                 '<td class="nowrap count minimal">' .
                 html::escapeHTML($this->rs->link_note) . '/20' .
                 '</td>',
-            'date' => '<td class="nowrap count minimal">' .
+            'date'   => '<td class="nowrap count minimal">' .
                 dt::dt2str(
                     dcCore::app()->blog->settings->system->date_format . ', ' . dcCore::app()->blog->settings->system->time_format,
                     $this->rs->link_upddt,