':' is not replaced in URLs #1

New issue

Closed

opened 2023-04-25 22:16:50 +00:00 by p4bl0- · 0 comments

p4bl0- commented

2023-04-25 22:16:50 +00:00

(Migrated from github.com)

Hello,

The : character is not replaced in URL while this should be the case.

    public static function cleanStr(?string $str): ?string
    {
        return is_null($str) ? null : strtr(self::removeAccents($str), ',!.?;', '-----');
    }

should be

    public static function cleanStr(?string $str): ?string
    {
        return is_null($str) ? null : strtr(self::removeAccents($str), ',!.?;:', '------');
    }

Some other characters than : that might be found in post titles should and are not currently replaced by this plugin includes : @, $, «, », °, and *.

So maybe:

    public static function cleanStr(?string $str): ?string
    {
        return is_null($str) ? null : strtr(self::removeAccents($str), ',!.?;:@$«»°*', '------------');
    }

Hello, The `:` character is not replaced in URL while this should be the case. ```php public static function cleanStr(?string $str): ?string { return is_null($str) ? null : strtr(self::removeAccents($str), ',!.?;', '-----'); } ``` should be ```php public static function cleanStr(?string $str): ?string { return is_null($str) ? null : strtr(self::removeAccents($str), ',!.?;:', '------'); } ``` Some other characters than `:` that might be found in post titles should and are not currently replaced by this plugin includes : `@`, `$`, `«`, `»`, `°`, and `*`. So maybe: ```php public static function cleanStr(?string $str): ?string { return is_null($str) ? null : strtr(self::removeAccents($str), ',!.?;:@$«»°*', '------------'); } ```