JcDenis/improve
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

lazy way to get dc_min

Browse source
This commit is contained in:
Jean-Christian Denis 2022-12-01 10:53:13 +01:00
parent e557293f80
commit 9645614c56
Signed by: JcDenis
GPG key ID: 1B5B8C5B90B6C951
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
_install.php
View file

@ -33,8 +33,6 @@ use Exception;
*/ */
class install class install
{ {
/** @var string Dotclear minimal version */
private static $dotclear_version = '2.24';
/** @var array Improve default settings */ /** @var array Improve default settings */
private static $default_settings = [[ private static $default_settings = [[
'disabled', 'disabled',
@ -52,7 +50,7 @@ class install
throw new Exception(sprintf( throw new Exception(sprintf(
'%s requires Dotclear %s', '%s requires Dotclear %s',
'improve', 'improve',
self::$dotclear_version self::getDotclearVersion()
)); ));
} }
@ -64,6 +62,11 @@ class install
return true; return true;
} }
private static function getDotclearVersion(): string
{
return dcCore::app()->plugins->moduleInfo('improve', 'requires')[0][1];
}
private static function getInstalledVersion(): string private static function getInstalledVersion(): string
{ {
$version = dcCore::app()->getVersion('improve'); $version = dcCore::app()->getVersion('improve');
@ -83,7 +86,7 @@ class install
private static function checkDotclearVersion(): bool private static function checkDotclearVersion(): bool
{ {
return method_exists('dcUtils', 'versionsCompare') return method_exists('dcUtils', 'versionsCompare')
&& dcUtils::versionsCompare(DC_VERSION, self::$dotclear_version, '>=', false); && dcUtils::versionsCompare(DC_VERSION, self::getDotclearVersion(), '>=', false);
} }
private static function putSettings(): void private static function putSettings(): void