JcDenis/saba
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

code review (phpstan)

Browse source
This commit is contained in:
Jean-Christian Denis 2023-11-04 21:34:46 +01:00
parent d65758cc69
commit 7b12eda8a5
Signed by: JcDenis
GPG key ID: 1B5B8C5B90B6C951
3 changed files with 34 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/FrontendBehaviors.php
View file

@ -20,6 +20,9 @@ use Dotclear\Core\Frontend\Ctx;
*/
class FrontendBehaviors
{
/**
* @param ArrayObject<string, mixed> $alias
*/
public static function templateCustomSortByAlias(ArrayObject $alias): void
{
$alias['post'] = [
@ -81,6 +84,11 @@ class FrontendBehaviors
App::frontend()->context()->__set('saba_options', $options);
}
/**
* @param ArrayObject<string, mixed> $params
*
* @return array<string, mixed>
*/
public static function getPostsParams(ArrayObject $params): array
{
if (!isset($params['sql'])) {
@ -91,7 +99,7 @@ class FrontendBehaviors
# retreive _GET
$qs = $_SERVER['QUERY_STRING'];
$qs = preg_replace('#(^|/)page/([0-9]+)#', '', $qs);
$qs = (string) preg_replace('#(^|/)page/([0-9]+)#', '', $qs);
parse_str($qs, $get);
# search string
@ -189,7 +197,11 @@ class FrontendBehaviors
return $options;
}
# Ajouter la condition "ou" à la recherche
/**
* Ajouter la condition "ou" à la recherche.
*
* @param ArrayObject<string, mixed> $p
*/
public static function coreBlogBeforeGetPosts(ArrayObject $p): void
{
if (empty($p['search'])) {

15
src/Utils.php
View file

@ -15,6 +15,9 @@ use Dotclear\App;
*/
class Utils
{
/**
* @return array<string, mixed>
*/
public static function getSabaDefaultPostsOptions(): array
{
return [
@ -29,6 +32,9 @@ class Utils
];
}
/**
* @return array<string, string>
*/
public static function getSabaFormOptions(): array
{
return [
@ -38,6 +44,9 @@ class Utils
];
}
/**
* @return array<string, string>
*/
public static function getSabaFormOrders(): array
{
return [
@ -51,6 +60,9 @@ class Utils
];
}
/**
* @return array<string, string>
*/
public static function getSabaFormAges(): array
{
return [
@ -62,6 +74,9 @@ class Utils
];
}
/**
* @return array<string, string>
*/
public static function getSabaFormTypes(): array
{
$know = [

10
src/Widgets.php
View file

@ -110,7 +110,7 @@ class Widgets
$ct .= '<li><label><input name="q_order" type="radio" value="' .
$v . '" ' .
($v == $saba_options['q_order'] ? 'checked="checked" ' : '') .
'/> ' . Html::escapeHTML($k) . '</label></li>';
'/> ' . Html::escapeHTML((string) $k) . '</label></li>';
}
if (!empty($ct)) {
$ct .= '<li><label><input name="q_rev" type="checkbox" value="1" ' .
@ -132,7 +132,7 @@ class Widgets
$ct .= '<li><label><input name="q_opt[]" type="checkbox" value="' .
$v . '" ' .
(in_array($v, $saba_options['q_opt']) ? 'checked="checked" ' : '') .
'/> ' . Html::escapeHTML($k) . '</label></li>';
'/> ' . Html::escapeHTML((string) $k) . '</label></li>';
}
if (!empty($ct)) {
$res .= $w->renderTitle(__('Filter options')) . sprintf('<ul>%s</ul>', $ct);
@ -147,7 +147,7 @@ class Widgets
$ct .= '<li><label><input name="q_age" type="radio" value="' .
$v . '" ' .
($v == $saba_options['q_age'] ? 'checked="checked" ' : '') .
'/> ' . Html::escapeHTML($k) . '</label></li>';
'/> ' . Html::escapeHTML((string) $k) . '</label></li>';
}
if (!empty($ct)) {
$res .= $w->renderTitle(__('Filter by age')) . sprintf('<ul>%s</ul>', $ct);
@ -166,7 +166,7 @@ class Widgets
$ct .= '<li><label><input name="q_type[]" type="checkbox" value="' .
$v . '" ' .
(in_array($v, $saba_options['q_type']) ? 'checked="checked" ' : '') .
'/> ' . Html::escapeHTML($k) . '</label></li>';
'/> ' . Html::escapeHTML((string) $k) . '</label></li>';
}
if (!empty($ct)) {
$res .= $w->renderTitle(__('Filter by type')) . sprintf('<ul>%s</ul>', $ct);
@ -186,7 +186,7 @@ class Widgets
$ct .= '<li><label><input name="q_cat[]" type="checkbox" value="' .
$rs->f('cat_id') . '" ' .
(in_array($rs->f('cat_id'), $saba_options['q_cat']) ? 'checked="checked" ' : '') .
'/> ' . Html::escapeHTML($rs->f('cat_title')) . '</label></li>';
'/> ' . Html::escapeHTML((string) $rs->f('cat_title')) . '</label></li>';
}
if (!empty($ct)) {
$res .= $w->renderTitle(__('Filter by category')) . sprintf('<ul>%s</ul>', $ct);